[PATCH] D117250: [lld-macho] Mention string literal deduplication as a difference from ld64

Jez Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 19 16:31:06 PST 2022


This revision was automatically updated to reflect the committed changes.
Closed by commit rGef95d45138ec: [lld-macho] Mention string literal deduplication as a difference from ld64 (authored by int3).

Changed prior to commit:
  https://reviews.llvm.org/D117250?vs=399774&id=401439#toc

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117250/new/

https://reviews.llvm.org/D117250

Files:
  lld/MachO/ld64-vs-lld.rst


Index: lld/MachO/ld64-vs-lld.rst
===================================================================
--- lld/MachO/ld64-vs-lld.rst
+++ lld/MachO/ld64-vs-lld.rst
@@ -4,6 +4,15 @@
 
 This doc lists all significant deliberate differences in behavior between LD64 and LLD-MachO.
 
+String literal deduplication
+****************************
+LD64 always deduplicates string literals. LLD only does it when the `--icf=` or
+the `--deduplicate-literals` flag is passed. Omitting deduplication by default
+ensures that our link is as fast as possible. However, it may also break some
+programs which have (incorrectly) relied on string deduplication always
+occurring. In particular, programs which compared string literals via pointer
+equality must be fixed to use value equality instead.
+
 ``-no_deduplicate`` Flag
 **********************
 - LD64:


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D117250.401439.patch
Type: text/x-patch
Size: 845 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220120/2d54861f/attachment.bin>


More information about the llvm-commits mailing list