[PATCH] D117356: InstructionCombining: avoid eliding mismatched alloc/free pairs

Yuanfang Chen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 19 15:41:41 PST 2022


ychen requested changes to this revision.
ychen added a comment.
This revision now requires changes to proceed.

Apologies if I didn't make myself clear.  The inlining of the allocator function step is already incorrect. This instcombine bailout is not a desirable direction since it implicitly assumes the earlier allocator inlining is correct but it is not. Whatever attributes would be added in the future should be used for preventing the C++ new/delete from doing any kinds of IPO/IPA (marking them to be deleted is allowed though).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117356/new/

https://reviews.llvm.org/D117356



More information about the llvm-commits mailing list