[PATCH] D115007: Dump swift5 reflection section data into dsym bundle generated binary with dsymutil

Jonas Devlieghere via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 19 15:39:23 PST 2022


JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.

LGTM modulo the early return.



================
Comment at: llvm/tools/dsymutil/DwarfLinkerForBinary.cpp:347-349
+  if (!OF) {
+    llvm::consumeError(OF.takeError());
+  } else {
----------------
Seems like an early return here could save you a level of indentation.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115007/new/

https://reviews.llvm.org/D115007



More information about the llvm-commits mailing list