[PATCH] D117250: [lld-macho] Mention string literal deduplication as a difference from ld64

Keith Smiley via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 19 15:25:03 PST 2022


keith added a comment.

In D117250#3254563 <https://reviews.llvm.org/D117250#3254563>, @oontvoo wrote:

> In D117250#3253510 <https://reviews.llvm.org/D117250#3253510>, @int3 wrote:
>
>>> the chances of them diving deep enough to understand why they're not are slim if they think it introduces too much risk
>>
>> How about introducing a new `--ld64-compat` flag that developers can use if they want to adopt LLD with minimal differences from ld64? I agree that it's not reasonable to expect the average end-user to understand the linking process in detail just to adopt LLD, but I think presenting them a higher-level flag that maximizes LD64 compatibility (and putting it front-and-center in our docs) makes things more approachable. Right now, that flag would simply alias to `--deduplicate-literals`, but we could expand it to other behaviors in the future.
>
> 👍  Good idea!

I like this idea too, but I wonder if we should wait until we have some more use cases for this? Because I do wonder if over time there will be very many of these that we can easily have a flag like this for.

It seems like the consensus has been reached to keep this flag as is, so we should land this so folks reading it have this info.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117250/new/

https://reviews.llvm.org/D117250



More information about the llvm-commits mailing list