[PATCH] D116784: [ProfileData] Read and symbolize raw memprof profiles.

[Snehasish Kumar via Phabricator via llvm-commits]

snehasish marked 2 inline comments as done.
snehasish added a comment.

PTAL, thanks!



================
Comment at: llvm/test/tools/llvm-profdata/memprof-basic.test:73
+CHECK-NEXT:       max_lifetime: 987
+CHECK-NEXT:       alloc_cpu_id: 4294967295
+CHECK-NEXT:       dealloc_cpu_id: 56
----------------
snehasish wrote:
> davidxl wrote:
> > is cpuid this big?
> It shouldn't be, this is 2^32-1 so let me check whats going on here.
The cpuid is unavailable since the allocation we captured occurs when memprof has not been fully initialized [1].

[1] https://github.com/llvm/llvm-project/blob/c7b71acef2685ca59830b5b59c6214b6dac474a2/compiler-rt/lib/memprof/memprof_allocator.cpp#L45


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116784/new/

https://reviews.llvm.org/D116784