[PATCH] D117650: [llvm][vfs] Implement in-memory symlinks

Duncan P. N. Exon Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 19 13:59:35 PST 2022


dexonsmith added a comment.

@sammccall, you've had objections in the past to exposing symbolic links in the `vfs::FileSystem` API, but this patch doesn't do that. It's just modelling symlink behaviour in an `InMemoryFileSystem`. Any concerns?

(I have none.)



================
Comment at: llvm/lib/Support/VirtualFileSystem.cpp:567
+  IME_HardLink,
+  IME_SymbolicLink
+};
----------------
Add a trailing `,` to avoid a diff if this gets extended again?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117650/new/

https://reviews.llvm.org/D117650



More information about the llvm-commits mailing list