[PATCH] D117665: [docs] Fix typo in the example code in ProgrammersManual.
Duncan P. N. Exon Smith via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jan 19 13:33:04 PST 2022
dexonsmith accepted this revision.
dexonsmith added a comment.
This revision is now accepted and ready to land.
Thanks for finding this! I think `processBuffer()` pairs better with `processBufferAtPath()` though so I suggest a different fix...
LGTM if you go with my alternate suggestion.
================
Comment at: llvm/docs/ProgrammersManual.rst:579
Expected<std::unique_ptr<MemoryBuffer>> openBuffer(StringRef Path);
- Error processBuffer(StringRef Buffer);
+ Error processContent(StringRef Buffer);
----------------
I think this should be left alone...
================
Comment at: llvm/docs/ProgrammersManual.rst:588
// On success, use MB.
return processContent(MB->getBuffer());
}
----------------
... and this should be changed to `processBuffer()`.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D117665/new/
https://reviews.llvm.org/D117665
More information about the llvm-commits
mailing list