[PATCH] D117634: [OpenMP] Expand short verisions of OpenMP offloading triples

[Jon Chesterfield via Phabricator via llvm-commits]

JonChesterfield accepted this revision.
JonChesterfield added a comment.
This revision is now accepted and ready to land.

LG, thanks!



================
Comment at: clang/lib/Driver/Driver.cpp:778
+          // We want to normalize the shortened versions of triples passed in to
+          // the values used for the bitcode libraries.
+          if (TT.getVendor() == llvm::Triple::UnknownVendor ||
----------------
Might be worth mentioning in the comment that this is essentially a user convenience feature. We're not so much normalising, as treating fopenmp-target=nvtpx64 as an abbreviation for nvptx64-nvidia-cuda


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117634/new/

https://reviews.llvm.org/D117634