[PATCH] D116270: [AMDGPU] Enable divergence-driven XNOR selection
Stanislav Mekhanoshin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Jan 19 10:24:41 PST 2022
rampitec added a comment.
I like this in general. @foad?
================
Comment at: llvm/lib/Target/AMDGPU/SIISelLowering.cpp:12485
+ return false;
+ return (
+ // Take care of the oportunity to keep N0 uniform
----------------
Please simplify this condition. Make separate "return false" probably. The part "((!(!" is unreadable.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116270/new/
https://reviews.llvm.org/D116270
More information about the llvm-commits
mailing list