[PATCH] D117244: [llvm-dis] Add an option `dump-thinlto-index-only` in llvm-dis to read ThinLTO minimized code only.

Mingming Liu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 19 10:13:32 PST 2022


luna added inline comments.


================
Comment at: llvm/lib/Bitcode/Reader/BitcodeReader.cpp:3269
+  //
+  // FIXME: BitcodeReader should handle GLOBALVAR written by
+  // ThinLinkBitcodeWriter. (see
----------------
tejohnson wrote:
> FYI looks like FUNCTION, ALIAS and IFUNC have the same issue. I'm not sure if there is a good common place to leave a comment about handling all of those?
Good point!

Moved this to switch statements of `BitcodeReader::parseModule`, mentioned other simplified records, and added a github pointer to `ThinLinkBitcodeWriter::writeSimplifiedModuleInfo` (in case the method itself was renamed in the future).


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117244/new/

https://reviews.llvm.org/D117244



More information about the llvm-commits mailing list