[PATCH] D117664: [Support] Remove incorrect noalias return attribute in BumpPtrAllocator

Nikita Popov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 19 09:54:55 PST 2022


nikic added a comment.

In D117664#3255143 <https://reviews.llvm.org/D117664#3255143>, @aganea wrote:

> There might more to it. Unfortunately I don't see any difference after the patch, either applied on rG3cef3cf02f09e397c471cf008060c89b34951959 <https://reviews.llvm.org/rG3cef3cf02f09e397c471cf008060c89b34951959> or on ToT. The repro still don't emit the `mov`s into the target buffer. Is anyone able to confirm?

When I tested this I dropped the `__attribute__((malloc))` from the preprocessed source, and that did it for me. Note that this patch needs to be in the source code for the stage2 lld build, not the stage1 clang build.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117664/new/

https://reviews.llvm.org/D117664



More information about the llvm-commits mailing list