[PATCH] D117677: [BOLT] Remove unreachable uncond branch after return

Vladislav Khmelevsky via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 19 09:42:46 PST 2022


yota9 added inline comments.


================
Comment at: bolt/test/X86/jmp-after-ret.s:18
+main:
+    je 1f
+    retq
----------------
Amir wrote:
> Are you sure `1f` here means the label and not a hex offset? Can you please use `.L1` instead to make it explicit?
This is default syntax for asm and called numeric label: https://docs.oracle.com/cd/E19120-01/open.solaris/817-5477/esqaq/index.html . I've checked the objdump for this (x86) and it works fine, and I'm sure about arm too :)  I often see such syntax in linux kernel, so I think it is OK if you don't mind :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117677/new/

https://reviews.llvm.org/D117677



More information about the llvm-commits mailing list