[PATCH] D117688: [flang][NFC] Cleanup dependent dialects and make def homogenous

Valentin Clement via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 19 08:44:54 PST 2022


clementval created this revision.
clementval added reviewers: jeanPerier, kiranchandramohan, schweitz.
Herald added a project: Flang.
clementval requested review of this revision.
Herald added a reviewer: jdoerfert.
Herald added subscribers: llvm-commits, sstefan1, jdoerfert.
Herald added a project: LLVM.

Remove unnecessary dependent dialect and make the definition of the
pass more homogenous with the two others.

This patch is part of the upstreaming effort from fir-dev branch.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D117688

Files:
  flang/include/flang/Optimizer/CodeGen/CGPasses.td


Index: flang/include/flang/Optimizer/CodeGen/CGPasses.td
===================================================================
--- flang/include/flang/Optimizer/CodeGen/CGPasses.td
+++ flang/include/flang/Optimizer/CodeGen/CGPasses.td
@@ -30,15 +30,14 @@
   ];
 }
 
-def CodeGenRewrite : Pass<"cg-rewrite"> {
+def CodeGenRewrite : Pass<"cg-rewrite", "mlir::ModuleOp"> {
   let summary = "Rewrite some FIR ops into their code-gen forms.";
   let description = [{
     Fuse specific subgraphs into single Ops for code generation.
   }];
-  let constructor = "fir::createFirCodeGenRewritePass()";
+  let constructor = "::fir::createFirCodeGenRewritePass()";
   let dependentDialects = [
-    "fir::FIROpsDialect", "fir::FIRCodeGenDialect", "mlir::BuiltinDialect",
-    "mlir::LLVM::LLVMDialect", "mlir::omp::OpenMPDialect"
+    "fir::FIROpsDialect", "fir::FIRCodeGenDialect"
   ];
   let statistics = [
     Statistic<"numDCE", "num-dce'd", "Number of operations eliminated">


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D117688.401262.patch
Type: text/x-patch
Size: 971 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20220119/50c558b9/attachment.bin>


More information about the llvm-commits mailing list