[PATCH] D117664: [Support] Remove incorrect noalias return attribute in BumpPtrAllocator

[Nikita Popov via Phabricator via llvm-commits]

nikic added a comment.

In D117664#3254874 <https://reviews.llvm.org/D117664#3254874>, @reames wrote:

> There's a couple more occurrences of noalias in the same file.

I don't see any other references apart from these two. We have another in MemAlloc.h, but that's unrelated (and legit).

> Removing this is unfortunate just to allow destruction, but it does seem to be required with the current code structure.  I think we could add Allocate wrappers on the standard bump pointer typedef (i.e turn it into a subclass) and preserve noalias there, but I'm fine landing the removal and then restructing if we see a regression.

Yeah, that might be possible. I think it wouldn't be strictly speaking correct, but likely wouldn't cause issues as long as SpecificBumpPtrAllocator is split out.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117664/new/

https://reviews.llvm.org/D117664