[PATCH] D117664: [Support] Remove incorrect noalias return attribute in BumpPtrAllocator

[Philip Reames via Phabricator via llvm-commits]

reames added a comment.

There's a couple more occurrences of noalias in the same file.  I think if we remove one, we need to remove all.  Please also add a comment explaining that these are *not* noalias and why.  (So we don't add the same bug back.)

Removing this is unfortunate just to allow destruction, but it does seem to be required with the current code structure.  I think we could add Allocate wrappers on the standard bump pointer typedef (i.e turn it into a subclass) and preserve noalias there, but I'm fine landing the removal and then restructing if we see a regression.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117664/new/

https://reviews.llvm.org/D117664