[PATCH] D117219: [LSV] Vectorize loads of vectors by turning it into a larger vector

Wed Jan 19 07:09:56 PST 2022

bkramer added inline comments.

================
Comment at: llvm/test/Transforms/LoadStoreVectorizer/NVPTX/4x2xhalf.ll:33
+  ret void
+
+; CHECK-LABEL: @ldg_f16
----------------
arsenm wrote:
> bkramer wrote:
> > arsenm wrote:
> > > Should add a larger variety of tests with more vector widths, particularly some 3 element vectors
> > Anything in particular you're looking for? Currently the pass also has the limitation of only creating vector sizes that are a power of 2, which means there is no interesting case for 3-element vectors.
> Not handling those is of interest itself? 
> 
> Vectors of pointers are always an interesting source of edge cases
I don't think that's a particularly valuable test, but added some.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117219/new/

https://reviews.llvm.org/D117219