[PATCH] D116493: [AVR] Generate ELPM for loading byte/word from extended program memory

Ben Shi via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 19 04:26:49 PST 2022


benshi001 added a comment.

I also have added a new test `foo4b` in the new test elpm.ll, which will show the case you mentioned:

  read twice from the same extended address space, and there only one LDI instruction to load the address space number.



In D116493#3251291 <https://reviews.llvm.org/D116493#3251291>, @aykevl wrote:

> This looks pretty good. Thanks for the improvements!
>
> Can you add a test where you read twice from the same extended address space? It should only have one `ldi` instruction to load the address space number.
>
> We should also save RAMPZ in interrupts on devices that support ELPM. But I guess that can happen in a separate patch.
> See for example: https://godbolt.org/z/x9Tx1jzMc




CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116493/new/

https://reviews.llvm.org/D116493



More information about the llvm-commits mailing list