[PATCH] D116660: [LoopFlatten] Update MemorySSA state

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 19 02:23:36 PST 2022


SjoerdMeijer added a comment.

In D116660#3252608 <https://reviews.llvm.org/D116660#3252608>, @asbirlea wrote:

> Changes LGTM.
> Nit: clang-format.
> A simpler way to check all verification is now to pass `VerificationLevel::Full` to `verifyMemorySSA()`; I'm mentioning this for your local testing, in case your build doesn't have EXPENSIVE_CHECKS on already, not to include in this patch.

I have applied clang-format, double checked locally `VerificationLevel::Full` (but was using an expensive checks build), and restored optionally allocating MSSAU.

Thanks for reviewing!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116660/new/

https://reviews.llvm.org/D116660



More information about the llvm-commits mailing list