[PATCH] D117317: [MC] Put the pending fixups into relocation offset symbol's fragment

luxufan via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Jan 19 01:25:13 PST 2022


StephenFan marked an inline comment as done.
StephenFan added inline comments.


================
Comment at: llvm/lib/MC/MCObjectStreamer.cpp:129
+    switch (SymFragment->getKind()) {
+    case MCFragment::FT_Relaxable:
+    case MCFragment::FT_Dwarf:
----------------
Hi @MaskRay , The test case of FT_Relaxable is not added. Because I don't know how to define a symbol which its fragment is FT_Relaxable. Do you have some ideas ?


================
Comment at: llvm/lib/MC/MCObjectStreamer.cpp:137
+    case MCFragment::FT_Data:
+    case MCFragment::FT_CVDefRange:
+      cast<MCEncodedFragmentWithFixups<32, 4>>(SymFragment)
----------------
I found that FT_CVDefRange is only used by COFF. Does COFF support `.reloc` directive? 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117317/new/

https://reviews.llvm.org/D117317



More information about the llvm-commits mailing list