[PATCH] D108416: [llvm-libgcc] initial commit

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added inline comments.


================
Comment at: llvm/tools/llvm-libgcc/generate_version_script.py:9
+def split_suffix(symbol):
+    """
+  Splits a symbol such as `__gttf2 at GCC_3.0` into a triple representing its
----------------
docstring formatting is not aligned


================
Comment at: llvm/tools/llvm-libgcc/generate_version_script.py:67
+  """
+    result = subprocess.run(args=['readelf', '-su', '--wide', path],
+                            capture_output=True)
----------------
llvm-readelf and drop --wide


================
Comment at: llvm/tools/llvm-libgcc/generate_version_script.py:126
+
+if __name__ == "__main__":
+    main()
----------------
Single quotes


================
Comment at: llvm/tools/llvm-libgcc/version-scripts/gcc_s-i386.ver:124
+};
+
----------------
delete trailing blank lines


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D108416/new/

https://reviews.llvm.org/D108416