[PATCH] D117542: [Coroutines] Offering llvm.coro.align intrinsic

Chuanqi Xu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 18 19:32:16 PST 2022


ChuanqiXu added a comment.

In D117542#3253443 <https://reviews.llvm.org/D117542#3253443>, @ychen wrote:

> In D117542#3253436 <https://reviews.llvm.org/D117542#3253436>, @ChuanqiXu wrote:
>
>> In D117542#3253429 <https://reviews.llvm.org/D117542#3253429>, @ychen wrote:
>>
>>> LGTM. A nit: it would be nice the name the test files with some suffix like align16, align64, etc.
>>
>> Do you mean renaming test filename from coro-align-02.ll to something like coro-align8 or coro-align16?
>
> Yep. As long as it hints at the differences among these similar tests.

Got it. I would do it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117542/new/

https://reviews.llvm.org/D117542



More information about the llvm-commits mailing list