[PATCH] D115007: Dump swift5 reflection section data into dsym bundle generated binary with dsymutil

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added inline comments.


================
Comment at: llvm/tools/dsymutil/DwarfLinkerForBinary.cpp:305
+  // omitted the reflection metadata.
+  if (Map.getTriple().isOSDarwin() && !Map.getBinaryPath().empty() &&
+      Options.FileType == OutputFileType::Object) {
----------------
I don't think the `Map.getTriple().isOSDarwin() &&` check is necessary.


================
Comment at: llvm/tools/dsymutil/DwarfLinkerForBinary.cpp:312
+    if (!ObjectEntry) {
+      llvm::consumeError(ObjectEntry.takeError());
+      return false;
----------------
It would be good to comment here:
```
// Any errors will be diagnosed later in the main loop, ignore them here.
``


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115007/new/

https://reviews.llvm.org/D115007