[PATCH] D117141: [CSSPGO] Print "csnested" instead of "preilnined" for SecFuncMetadata.

Wenlei He via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 18 15:11:56 PST 2022


wenlei added inline comments.


================
Comment at: llvm/lib/ProfileData/SampleProfReader.cpp:1292
     if (hasSecFlag(Entry, SecFuncMetadataFlags::SecFlagIsCSNested))
-      Flags.append("preinlined,");
+      Flags.append("csnested,");
     break;
----------------
nit: `csnested` -> `context-nested` because we use `context` for `SecFlagFullContext`

Additionally, would it make sense for `SecFlagIsCSNested` to be a flag for `SecProfSummaryFlags` just like `SecFlagFullContext`?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117141/new/

https://reviews.llvm.org/D117141



More information about the llvm-commits mailing list