[PATCH] D117026: GlobalISel: Fix CSEMIRBuilder mishandling constant folds of vectors
Matt Arsenault via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Jan 18 14:22:42 PST 2022
arsenm added a comment.
In D117026#3234956 <https://reviews.llvm.org/D117026#3234956>, @paquette wrote:
> +1 for avoiding the copy if possible, otherwise looks fine to me?
DstOps is part of the MachineIRBuilder API, so I'm not sure it should be spread to Utils. However since this is using it anyway, why is ConstantFoldVectorBinop in Utils? We could either move the whole function into the MIRBuilder, or have the utils function return a vector of APInt
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D117026/new/
https://reviews.llvm.org/D117026
More information about the llvm-commits
mailing list