[PATCH] D117412: [lld][WebAssembly] Perform data relocations during start function

[Sam Clegg via Phabricator via llvm-commits]

sbc100 added inline comments.


================
Comment at: lld/wasm/Writer.cpp:1266-1273
+      if (!WasmSym::initMemory) {
+        // When initMemory is present it calls applyDataRelocs
+        if (WasmSym::applyDataRelocs) {
+          writeU8(os, WASM_OPCODE_CALL, "CALL");
+          writeUleb128(os, WasmSym::applyDataRelocs->getFunctionIndex(),
+                       "function index");
+        }
----------------
tlively wrote:
> Can we add a test that exercises this case?
I think we have coverage of all three branches above now.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117412/new/

https://reviews.llvm.org/D117412