[PATCH] D117591: A readonly operand bundle should not prevent inference of readonly from a readnone callee

[Philip Reames via Phabricator via llvm-commits]

reames added inline comments.


================
Comment at: llvm/include/llvm/IR/InstrTypes.h:2293
+  // know if an attribute's semantics are implied, not whether the attribute
+  // is actually present.  This distinction only exists when checking whether
+  // something is readonly or writeonly since readnone implies both.  The case
----------------
fhahn wrote:
> reames wrote:
> > fhahn wrote:
> > > Nit: 2 spaces before `This`.
> > There appear to already be two?  Did you maybe mean you wanted one?  (At least from my memory of high school grammar, two is "correct".)
> Oh right, I can only speak from experience in other places in LLVM and it seems more often than not single spaces are used. Not a big deal though, I just thought it might have been a typo.
I think this is one of those where actual usage varies widely, and it doesn't really matter.  


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117591/new/

https://reviews.llvm.org/D117591