[PATCH] D117509: [PartialInline] Bail out on asm-goto/callbr

Tue Jan 18 11:56:13 PST 2022

hoy added inline comments.

================
Comment at: llvm/lib/Transforms/IPO/PartialInlining.cpp:1420
+    // Don't bother with BlockAddress used by CallBr for asm goto.
+    if (isa<BlockAddress>(User))
+      continue;
----------------
davidxl wrote:
> hoy wrote:
> > davidxl wrote:
> > > Is it legal to partial inline in case when the function's block address is taken?
> > I think so. The non-inlined callsites will still call the original version, while the inlined callsites will pull in the new version. The new version has some context-irrelevant code outlined, but both versions should be semantically equal. Please correct me if I'm missing anything?
> what if the labels and references from asm goto are in different regions -- one in inlined region, and the other in the outllined region?
If internal blocks of an inlinee are address taken, the inlining should be disabled during the cost analysis: https://github.com/llvm/llvm-project/blob/main/llvm/lib/Analysis/InlineCost.cpp#L2656

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117509/new/

https://reviews.llvm.org/D117509