[PATCH] D117203: [Attributor] Remove notional overindexing check

[Nikita Popov via Phabricator via llvm-commits]

nikic added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/AttributorAttributes.cpp:1185
           return true;
-        if (!CE->isGEPWithNoNotionalOverIndexing()) {
+        auto *GEP = cast<GEPOperator>(CE);
+        if (!GEP || !GEP->hasAllConstantIndices()) {
----------------
jdoerfert wrote:
> dyn_cast? I agree we can drop the indices check. We need to verify it's a GEP though, at least given the code as it is.
Ooops, this was indeed supposed to be dyn_cast. Thanks for catching!


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117203/new/

https://reviews.llvm.org/D117203