[PATCH] D115847: [mlgo][inline] Improve global state tracking

[Mircea Trofin via Phabricator via llvm-commits]

mtrofin added inline comments.


================
Comment at: llvm/lib/Analysis/MLInlineAdvisor.cpp:158
+  for (const auto *N : NodesInLastSCC) {
+    if (N->isDead() || N->getFunction().isDeclaration())
+      continue;
----------------
aeubanks wrote:
> mtrofin wrote:
> > aeubanks wrote:
> > > does this come up? the CGSCC infra only visits function definitions
> > N->isDead could happen if the function for N died since. The second part - not sure, I could imagine a pass converting an implementation to an intrinsic? 
> a pass wouldn't replace the node with an intrinsic, every node is required to have a function definition
> so I'd remove the check for a function declaration
made into an assert.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D115847/new/

https://reviews.llvm.org/D115847