[PATCH] D117562: [AMDGPU] Sink immediate VGPR defs if high RP

Vang Thao via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 18 08:36:43 PST 2022


vangthao added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/GCNPreRAOptimizations.cpp:335
+
+  // If occupancy is at 1 then attempt to sink immediate vgpr defs that may
+  // have been hoisted by MachineLICM to loop preheader back into loop in an
----------------
foad wrote:
> What's special about occupancy 1?
There is nothing special about occupancy 1 in particular. I am only using 1 as the minimum because it fixes a regression case we are seeing in SWDEV-316487.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117562/new/

https://reviews.llvm.org/D117562



More information about the llvm-commits mailing list