[PATCH] D117412: [lld][WebAssembly] Perform data relocations during start function

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 18 07:54:05 PST 2022


sbc100 added a comment.

In D117412#3250155 <https://reviews.llvm.org/D117412#3250155>, @tlively wrote:

> Who was previously responsible for applying the data relocs? If it was Emscripten runtime code, does that mean this change will have to land alongside the corresponding Emscripten change? Is there anyone who would be broken by this ABI break who we should notify?

Previously it was treated as the very first ctor in `__wasm_call_ctors`.. (which emscripten take care of calling).   Now it happens earlier, removing that window where the relocations have not yet been applied.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117412/new/

https://reviews.llvm.org/D117412



More information about the llvm-commits mailing list