[PATCH] D117140: [LV] Always create VPWidenCanonicalIVRecipe, optimize away later.

Florian Hahn via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 18 05:41:27 PST 2022


fhahn marked 7 inline comments as done.
fhahn added a comment.

In D117140#3250984 <https://reviews.llvm.org/D117140#3250984>, @Ayal wrote:

> This is fine, thanks for accommodating, one last thought: does Canonical mean starting at zero, or possibly at EPResumeVal?

I think checking for zero a the moment should suffice, as EPResumeVal will only be set as start value just before epilogue VPlan execution. This should also match the current behavior before the change (and  D117551 <https://reviews.llvm.org/D117551> which now contains the addition if `isCanonical`). Once a single plan contains both vector loops we might need some changes in that direction though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117140/new/

https://reviews.llvm.org/D117140



More information about the llvm-commits mailing list