[PATCH] D117451: [MCA] Proposing the InstrPostProcess:modifyInstrDesc() method.

[Andrea Di Biagio via Phabricator via llvm-commits]

andreadb added a comment.

In D117451#3250015 <https://reviews.llvm.org/D117451#3250015>, @holland11 wrote:

> Okay, that makes a lot of sense.
>
> Since `CustomBehaviour` and `InstrPostProcess::postProcessInstruction()` are already capable of //adding// new dependencies, the main two purposes of this patch were to
>
> 1. Be able to modify the flags contained within `InstrDesc`.
> 2. Be able to //remove// dependencies.
>
> I'll think about this for a bit then most likely modify the patch to allow for //removing// uses / defs (likely through an `Ignored` flag like you suggested) and to have a more restrictive API. I'll consider adding the ability to add implicit uses / defs (not explicit ones), but that isn't as much of a priority in my mind so if an elegant solution to it doesn't come to me then I probably won't add it.
>
> Will also wrap the debug functions with `NDEBUG`.

Sounds good.

Thanks


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117451/new/

https://reviews.llvm.org/D117451