[PATCH] D117416: [clang-format] Handle C variables with name that matches c++ access specifier

Marek Kurdej via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 18 01:57:37 PST 2022


curdeius added inline comments.


================
Comment at: .arclint:15-16
   }
-}
+}
\ No newline at end of file

----------------
MyDeveloperDay wrote:
> curdeius wrote:
> > Please don't change unrelated files.
> I don't know about others but I personally don't use arcanist...
> 
> I stage my files, make a patch and upload manually
> 
> ```
> git add <files being modified>  (or `git ls files -m | xargs git add` )
> git clang-format 
> git diff --cached -U4 > patch_to_submitt.diff
> 
> ```
> I use the Create Diff/Update Diff functionality via the web interface (I feel that gives me more control)
> 
> {F21699407, size=full}
> 
> {F21699405, size=full}
> 
> Just my 2c
I do, but I never had to modify `.arclint` or whatever config file arcanist uses.
It just works as a charm.

Create and send a patch (if sending all changes not in main branch):
```
arc diff main --reviewers ...
```
Update a patch:
```
arc diff main --update --revision D123456789
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117416/new/

https://reviews.llvm.org/D117416



More information about the llvm-commits mailing list