[PATCH] D117544: [AMDGPU] Fix missing waitcnt issue

Jay Foad via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Jan 18 00:29:42 PST 2022


foad added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIInsertWaitcnts.cpp:1428
 
-    if (RegStrictDom && !OldOutOfOrder)
       StrictDom = true;
----------------
foad wrote:
> As an experiment, would changing the condition to `RegStrictDom && !OldOutOfOrder && MyPending != 0` also fix the bug?
> As an experiment, would changing the condition to `RegStrictDom && !OldOutOfOrder && MyPending != 0` also fix the bug?

Sorry I meant `RegStrictDom && !(OldOutOfOrder && MyPending != 0)`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117544/new/

https://reviews.llvm.org/D117544



More information about the llvm-commits mailing list