[PATCH] D117385: [RISCV] Add patterns for vector widening integer multiply

[Jianjian Guan via Phabricator via llvm-commits]

jacquesguan added inline comments.


================
Comment at: llvm/lib/Target/RISCV/RISCVInstrInfoVSDPatterns.td:600
+                                   "PseudoVWMULU">;
+defm : VPatWidenBinarySDNode_VV_VX<mul, zext_oneuse, anyext_oneuse,
+                                   "PseudoVWMULU">;
----------------
craig.topper wrote:
> You don't need to handle both orders or zext/anyext. Tablegen knows mul is commutable and will autogenerate the swapped version. Sorry I suspected you might not know that and should have mentioned it.
Done, thanks a lot.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117385/new/

https://reviews.llvm.org/D117385