[PATCH] D117387: [lld-macho] Allow deduplicate-literals to be overridden

Jez Ng via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 17 21:52:33 PST 2022


int3 added inline comments.


================
Comment at: lld/MachO/Driver.cpp:1266
+  config->dedupLiterals =
+      args.hasFlag(OPT_deduplicate_literals, OPT_icf_eq, false) ||
+      config->icfLevel != ICFLevel::none;
----------------
smeenai wrote:
> I'm confused ... was the second argument meant to be `OPT_no_deduplicate`? The test seems to be passing though...
`-no_deduplicate` aliases to setting `OPT_icf_eq` to false :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117387/new/

https://reviews.llvm.org/D117387



More information about the llvm-commits mailing list