[PATCH] D117439: [ELF] Update .relr.dyn once in the absence of SECTIONS commands

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 17 16:12:46 PST 2022


MaskRay added a comment.

You are right. `target->needsThunks` targets cannot use this optimization, either. `InputSectionDescription` spacing is not fixed in the presence of thunks.

Now this optimization seems unworthy because of the complexity to `finalizeAddressDependentContent`.

If `!script->hasSectionsCommand` and there is no symbol assignment (the majority of x86 programs), `script->assignAddresses` can be called only once.
But adding the condition make need to complicate `finalizeAddressDependentContent`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117439/new/

https://reviews.llvm.org/D117439



More information about the llvm-commits mailing list