[PATCH] D109240: GlobalISel: Artifact combine merge-like opcode and unmerge into copy

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/GlobalISel/LegalizationArtifactCombiner.h:1081
 
+  bool tryCombineMergeLike(GMergeLikeOp &MI,
+                           SmallVectorImpl<MachineInstr *> &DeadInsts,
----------------
Petar.Avramovic wrote:
> arsenm wrote:
> > Should this be merged in with ArtifactValueFinder?
> Do you mean whole function or some parts?
> To me this looks similar to other tryCombine functions. 
> build_vector combines should be very simple, two adjacent instructions starting from build_vector check for elements shuffles. ArtifactValueFinder does advanced look through calculations (mainly through G_INSERT).
> @aemerson What do you think?
I thought the plan was to move everything toward using ArtifactValueFinder, rather than continuing to try to add code to parse every permutation of artifacts


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D109240/new/

https://reviews.llvm.org/D109240