[PATCH] D104034: [flang] Fixed simple typo in runtime code

Mon Jan 17 14:53:59 PST 2022

jrtc27 added a comment.
Herald added a project: Flang.

This was committed with the author email set to the empty string. Git seems happy enough to create it (though I suspect it shouts at you still), but rebasing chokes with:

  fatal: empty ident name (for <Zachary Selk>) not allowed

Arguably this inconsistency is a bug in Git, but at the same time the commit was bogus. I see also your most recent commit, https://reviews.llvm.org/rZORG5a4757532b3e92a287cce159739e36717b7ab682, is similarly missing an author email. Can you please make sure you've fixed your config so this never happens again? It is a real pain to deal with in our workflow as it totally breaks git-subrepo (https://github.com/ingydotnet/git-subrepo), at least when used in rebase mode.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104034/new/

https://reviews.llvm.org/D104034