[PATCH] D117226: [OpenMPIRBuilder] Detect and fix ambiguous InsertPoints for createParallel.

Michael Kruse via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 17 13:37:58 PST 2022


Meinersbur added a comment.

In D117226#3243433 <https://reviews.llvm.org/D117226#3243433>, @kiranchandramohan wrote:

> Nit: It seems the same code is codded to quite a few tests. Would it make sense to factor out the common portion?

A subsequent patch will introduce functionality to make the splitting of BB as the current IP easier, most likely reducing it to a single line.

If we want to avoid repetitive code, the more complete solution would be to factor out the entire `using InsertPointTy = ...` prologue; for instance, in a fixture.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117226/new/

https://reviews.llvm.org/D117226



More information about the llvm-commits mailing list