[PATCH] D117469: [LegalizeTypes][VP] Add splitting support for vp.reduction.*

[Craig Topper via Phabricator via llvm-commits]

craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.

LGTM other than that assertion request.



================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp:2463
+SDValue DAGTypeLegalizer::SplitVecOp_VP_REDUCE(SDNode *N, unsigned OpNo) {
+  unsigned Opc = N->getOpcode();
+  EVT ResVT = N->getValueType(0);
----------------
Should assert OpNo==1? The creation of the new nodes is only correct if it is.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117469/new/

https://reviews.llvm.org/D117469