[PATCH] D117180: [BasicAliasAnalysis] Switch from isMallocOrCallocLikeFn to onlyAccessesInaccessibleMemory

[Bryce Wilson via Phabricator via llvm-commits]

Bryce-MW added a comment.

>From my perspective, since the return value is noalias, I feel like that memory is inaccessible until it is returned so anything done to that memory, such as clearing it, should be fine. It seems like the issue that they had was with various bailouts for inaccessible memory in llvm/lib/Transforms/Scalar/DeadStoreElimination.cpp. We do have a check for an allocation function in storeIsNoop. I don't know if that happens before the other checks but it seems at least worth testing to see whether the old issue still occurs on today's code: https://github.com/llvm/llvm-project/issues/49487. It probably wouldn't be hard to add a test for that


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117180/new/

https://reviews.llvm.org/D117180