[PATCH] D116846: [MLIR] Fix compilation with LLVM_ENABLE_THREADS=OFF

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 17 12:05:24 PST 2022


MaskRay added inline comments.


================
Comment at: llvm/lib/Support/ThreadPool.cpp:121
+bool ThreadPool::isWorkerThread() const {
+  assert(false && "LLVM compiled with threading disabled");
+}
----------------
dexonsmith wrote:
> Perhaps `llvm::report_fatal_error()` would be appropriate here.
There was a -Wreturn-type warning in `-DLLVM_ENABLE_THREADS=OFF -DLLVM_ENABLE_ASSERTIONS=off` build.

Fixed by 27cb5eea00a8841323f16d5914d9dec29eb03ef7


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D116846/new/

https://reviews.llvm.org/D116846



More information about the llvm-commits mailing list