[PATCH] D104367: [AIX] Support of Big archive (write)

Digger Lin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Jan 17 11:08:02 PST 2022


DiggerLin added a comment.

would you like to rebase the patch based on the https://reviews.llvm.org/D111889([AIX] Support of Big archive (read))  ?, since the patch https://reviews.llvm.org/D111889 landed.



================
Comment at: llvm/lib/Object/ArchiveWriter.cpp:228
+    Out << (char)0; // Padding with null caracter
+  printWithSpacePadding(Out, "`\n", 2); // Terminator
+}
----------------
the terminator is "0x60 0x0a".


================
Comment at: llvm/lib/Object/ArchiveWriter.cpp:362
+    printBigMemberHeader(Out, Out.tell(), Name, now(Deterministic),
+                     0, 0, 0, Size, 0);
   } else {
----------------
the value of argument of  PrevOffset is not zero, it point to the "Member Table"


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104367/new/

https://reviews.llvm.org/D104367



More information about the llvm-commits mailing list