[PATCH] D117014: AMDGPU: Use removeAllRegUnitsForPhysReg()

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/SIWholeQuadMode.cpp:1590
   // the analysis results.
   LIS->removeRegUnit(*MCRegUnitIterator(MCRegister::from(AMDGPU::SCC), TRI));
 
----------------
foad wrote:
> Can you use it here too?
There's only one regunit so there's no difference


================
Comment at: llvm/lib/Target/AMDGPU/SIWholeQuadMode.cpp:1594
   if (!KillInstrs.empty())
-    LIS->removeRegUnit(*MCRegUnitIterator(AMDGPU::EXEC, TRI));
+    LIS->removeAllRegUnitsForPhysReg(AMDGPU::EXEC);
 
----------------
EXEC is reserved, so does the liveness actually exist?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117014/new/

https://reviews.llvm.org/D117014