[PATCH] D117469: [LegalizeTypes][VP] Add splitting support for vp.reduction.*

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeTypes.h:822
+  /// Split mask operator of a VP intrinsic.
+  std::pair<SDValue, SDValue> SplitMask(const SDValue &Mask);
+
----------------
`const SDValue &` can be `SDValue`. `SDValue` is cheap to copy.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp:2489
+
+  return DAG.getNode(CombineOpc, dl, ResVT, ResLo, ResHi, Flags);
+}
----------------
This isn't valid for SEQ_FADD or SEQ_FMUL. We can't evaluate the Lo and Hi split, that would break the sequentialness.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117469/new/

https://reviews.llvm.org/D117469