[PATCH] D117180: [BasicAliasAnalysis] Switch from isMallocOrCallocLikeFn to onlyAccessesInaccessibleMemory

[Nikita Popov via Phabricator via llvm-commits]

nikic added a comment.

In D117180#3248804 <https://reviews.llvm.org/D117180#3248804>, @reames wrote:

> I'm skimming the BasicAA code, and I don't see where we handle the isNoAliasCall case inside of getModRefInfo(CB, Loc).  Is it possible the effect here was because this was the only form of handling we had for noalias results?

Noalias calls are considered local identified objects, and are considered in any code dealing with those. For calls specifically, we don't modref local identified not-captured-before objects.

> Another possibility: We appear to not be annotating calloc with inaccessiblememonly.

Good point!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117180/new/

https://reviews.llvm.org/D117180