[PATCH] D117499: [CodeGen] Support extracting fixed-length vectors from illegal scalable vectors

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp:2532
     return DAG.getNode(ISD::EXTRACT_SUBVECTOR, dl, SubVT, Lo, Idx);
-  } else {
+  } else if (SubVT.isScalableVector() ==
+             N->getOperand(0).getValueType().isScalableVector()) {
----------------
Drop else after return


================
Comment at: llvm/lib/CodeGen/SelectionDAG/LegalizeVectorTypes.cpp:2536
                        DAG.getVectorIdxConstant(IdxVal - LoElts, dl));
+  } else {
+    // Spill the vector to the stack. We should use the alignment for
----------------
Drop else after return


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117499/new/

https://reviews.llvm.org/D117499