[PATCH] D117494: AMDGPU: Account for usage HIP-style dynamic LDS

[Matt Arsenault via Phabricator via llvm-commits]

arsenm added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUPromoteAlloca.cpp:787
+  for (const GlobalVariable *GV : UsedLDS) {
+    if (GV->hasExternalLinkage()) {
+      LocalMemLimit = 0;
----------------
arsenm wrote:
> The dynamic behavior is keyed on this being a 0 size allocation, not external linkage. Some of the graphics usage has external LDS with fixed, static sizes
You also don't need a separate loop, can move down to the existing loop over UsedLDS


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D117494/new/

https://reviews.llvm.org/D117494